Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXT-38863 - implement new text editor component #377

Merged
merged 9 commits into from
Jan 7, 2025

Conversation

jleifeld
Copy link
Contributor

@jleifeld jleifeld commented Nov 21, 2024

What?

Implement a text editor component with tiptap. Complete documentation and usage of the documentation can be found in Storybook: "Components/Form/mt-text-editor/docs". I recommend to read the documentation there to understand how it can be used.

Images

Bildschirmfoto 2024-12-11 um 09 33 53 Bildschirmfoto 2024-12-11 um 09 34 09

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
meteor-component-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 1:15pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
meteor-admin-sdk-docs ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 1:15pm

@jleifeld jleifeld force-pushed the next-38863/implement-new-text-editor-component branch from 5f72e3a to 266577f Compare November 22, 2024 15:39
@jleifeld jleifeld force-pushed the next-38863/implement-new-text-editor-component branch from 266577f to 143125f Compare December 5, 2024 16:03
@jleifeld jleifeld force-pushed the next-38863/implement-new-text-editor-component branch from 143125f to 9caec18 Compare December 6, 2024 15:53
@jleifeld jleifeld force-pushed the next-38863/implement-new-text-editor-component branch from 9caec18 to a25a47b Compare December 10, 2024 14:35
@jleifeld jleifeld force-pushed the next-38863/implement-new-text-editor-component branch from a25a47b to bdbf50f Compare December 10, 2024 15:56
@jleifeld jleifeld force-pushed the next-38863/implement-new-text-editor-component branch from bdbf50f to 5a0c1d7 Compare December 11, 2024 08:23
@jleifeld jleifeld force-pushed the next-38863/implement-new-text-editor-component branch from 5a0c1d7 to 5cdd87b Compare December 11, 2024 08:33
@jleifeld jleifeld marked this pull request as ready for review December 11, 2024 08:38
@jleifeld jleifeld force-pushed the next-38863/implement-new-text-editor-component branch from 5cdd87b to 32638d5 Compare December 11, 2024 08:47
@jleifeld
Copy link
Contributor Author

jleifeld commented Dec 20, 2024

I just saw during the platform migration that the following features are missing:

  • placeholder
  • error
  • general disabled
  • label

// EDIT:
Was added now

@seggewiss seggewiss self-requested a review December 20, 2024 08:36
seggewiss
seggewiss previously approved these changes Dec 20, 2024
@jleifeld jleifeld merged commit b3039c1 into main Jan 7, 2025
13 of 15 checks passed
@jleifeld jleifeld deleted the next-38863/implement-new-text-editor-component branch January 7, 2025 12:14
Haberkamp pushed a commit that referenced this pull request Jan 8, 2025
* NEXT-38863 - implement new text editor component

* Refactor translations to native i18n plugin

* NEXT-38863 - fix pipeline jobs

* Apply code formatting and fixable ESLint issues

* Apply code formatting and fixable ESLint issues

* Apply code formatting and fixable ESLint issues

* NEXT-38863 - add properties disabled, placeholder, label and error

* Apply code formatting and fixable ESLint issues

* NEXT-38863 - update snapshots and changelog

---------

Co-authored-by: jleifeld <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request package: components @meteor/components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants