Change default size of button to default #400
Open
+140
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Haberkamp
force-pushed
the
change-default-size-of-button-to-default
branch
from
262b9e7 to
7135168
Compare
Lucsy3012
reviewed
Dec 3, 2024
packages/component-library/src/components/form/mt-button/mt-button.vue
Outdated
Show resolved
Hide resolved
alastair-simon
previously approved these changes
Dec 3, 2024
@shopware-ag/meteor-admin-sdk
@shopware-ag/stylelint-plugin-meteor
@shopware-ag/meteor-icon-kit
@shopware-ag/meteor-component-library
@shopware-ag/meteor-tokens
commit: |
Haberkamp
force-pushed
the
change-default-size-of-button-to-default
branch
from
7135168 to
2f810e8
Compare
Lucsy3012
approved these changes
Dec 3, 2024
alastair-simon
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Changes the default size to
defaultfor themt-buttoncomponent.Why?
When there's size called
defaultthen it should be the default size.How?
I changed the size to
defaultTesting?
The visual tests will catch issues.
Anything Else?
Depends on #399