Improve colorpicker accessibility #435
Closed
+471
−329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
alastair-simon
force-pushed
the
improve-colorpicker-accessibility
branch
from
a2154c9 to
4b54b66
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
alastair-simon
force-pushed
the
improve-colorpicker-accessibility
branch
from
794afd8 to
afc0ec1
Compare
alastair-simon
force-pushed
the
improve-colorpicker-accessibility
branch
from
c490831 to
9755f70
Compare
alastair-simon
force-pushed
the
improve-colorpicker-accessibility
branch
from
bc22f8c to
226dc91
Compare
alastair-simon
force-pushed
the
improve-colorpicker-accessibility
branch
from
226dc91 to
329f661
Compare
Lucsy3012
previously approved these changes
Jan 16, 2025
@shopware-ag/meteor-admin-sdk
@shopware-ag/meteor-component-library
@shopware-ag/stylelint-plugin-meteor
@shopware-ag/meteor-icon-kit
@shopware-ag/meteor-tokens
commit: |
alastair-simon
force-pushed
the
improve-colorpicker-accessibility
branch
from
12de44a to
e9f1aa5
Compare
auto-merge was automatically disabled
January 20, 2025 16:29
Pull request was closed
|
Closing to resubmit with a cleaner branch structure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Improve the accessibility of the mt-colorpicker component
Why?
Currently the colorpicker does not allow focus tabbing for navigation, making it in-accessable for users without a cursor.
How?
Using the Focus-trap dependancy to allow focus navigation inside the colorpicker modal