Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backend voucher individual code search #2671

Merged
merged 1 commit into from
May 21, 2024

Conversation

Dominikrt
Copy link
Contributor

@Dominikrt Dominikrt commented Apr 24, 2024

Hi,

1. Why is this change necessary?

the individual voucher code search is broken, after a reload the store lose its filter

2. What does this change do, exactly?

the last filter get cleared bevor and not after the search method.

3. Describe each step to reproduce the issue or behaviour.

open a individual voucher and search for a code, after a list reload the filter gets cleared.

4. Please link to the relevant issues (if any).

5. Which documentation changes (if any) need to be made because of this PR?

6. Checklist

  • I have written tests and verified that they fail without my change
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

Copy link

github-actions bot commented Apr 24, 2024

Warnings
⚠️ The Pull Request doesn't contain any changes to the Upgrade file

@Dominikrt Dominikrt marked this pull request as draft April 24, 2024 18:05
@Dominikrt Dominikrt force-pushed the fix-backend-voucher-individual-code branch 2 times, most recently from 7f3d5fc to 1753c53 Compare April 30, 2024 19:19
@Dominikrt Dominikrt marked this pull request as ready for review April 30, 2024 19:57
@mitelg mitelg assigned mitelg and Dominikrt and unassigned mitelg May 16, 2024
@Dominikrt Dominikrt force-pushed the fix-backend-voucher-individual-code branch from 2fcc11f to f23abef Compare May 18, 2024 11:12
@Dominikrt Dominikrt requested a review from mitelg May 18, 2024 12:10
@mitelg mitelg added review and removed Incomplete labels May 21, 2024
@mitelg mitelg merged commit 2ac9e0f into shopware5:5.7 May 21, 2024
24 checks passed
@mitelg
Copy link
Contributor

mitelg commented May 21, 2024

thanks again for your contribution @Dominikrt 👍🎉💙

@mitelg mitelg added Accepted and removed review labels May 21, 2024
@Dominikrt Dominikrt deleted the fix-backend-voucher-individual-code branch May 21, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants