Skip to content

Commit

Permalink
chore(shorebird_cli): remove --channel option from patch and `pre…
Browse files Browse the repository at this point in the history
…view` commands (#1342)
  • Loading branch information
felangel authored Oct 2, 2023
1 parent a975dd6 commit 1aa7ecf
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 20 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,6 @@ class PatchAndroidCommand extends ShorebirdCommand
'flavor',
help: 'The product flavor to use when building the app.',
)
..addOption(
'channel',
help: 'The channel to publish the patch to.',
defaultsTo: 'stable',
)
..addFlag(
'force',
abbr: 'f',
Expand Down Expand Up @@ -102,7 +97,7 @@ class PatchAndroidCommand extends ShorebirdCommand
await cache.updateAll();

const platform = ReleasePlatform.android;
final channelName = results['channel'] as String;
const channelName = 'stable';
final flavor = results['flavor'] as String?;
final target = results['target'] as String?;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,6 @@ class PatchIosCommand extends ShorebirdCommand
'flavor',
help: 'The product flavor to use when building the app.',
)
..addOption(
'channel',
help: 'The channel to publish the patch to.',
defaultsTo: 'stable',
)
..addFlag(
'codesign',
help: 'Codesign the application bundle.',
Expand Down Expand Up @@ -100,7 +95,7 @@ class PatchIosCommand extends ShorebirdCommand
}

const arch = 'aarch64';
final channelName = results['channel'] as String;
const channelName = 'stable';
const releasePlatform = ReleasePlatform.ios;
final flavor = results['flavor'] as String?;

Expand Down
7 changes: 1 addition & 6 deletions packages/shorebird_cli/lib/src/commands/preview_command.dart
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,6 @@ class PreviewCommand extends ShorebirdCommand {
ReleasePlatform.ios.name: 'iOS',
},
help: 'The platform of the release.',
)
..addOption(
'channel',
defaultsTo: 'stable',
help: 'The channel to preview the release for.',
);
}

Expand Down Expand Up @@ -111,7 +106,7 @@ class PreviewCommand extends ShorebirdCommand {
);

final deviceId = results['device-id'] as String?;
final channel = results['channel'] as String;
const channel = 'stable';

return switch (platform) {
ReleasePlatform.android => installAndLaunchAndroid(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ void main() {
const version = '$versionName+$versionCode';
const arch = 'aarch64';
const releasePlatform = ReleasePlatform.android;
const channelName = 'test-channel';
const channelName = 'stable';
const appDisplayName = 'Test App';
final appMetadata = AppMetadata(
appId: appId,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ void main() {
const versionCode = '1';
const version = '$versionName+$versionCode';
const arch = 'aarch64';
const channelName = 'test-channel';
const channelName = 'stable';
const appDisplayName = 'Test App';
const releasePlatform = ReleasePlatform.ios;
const platformName = 'ios';
Expand Down

0 comments on commit 1aa7ecf

Please sign in to comment.