chore(shorebird_cli): add http.ClientException to list of retry-abl…

…e errors (#945)
shorebirdtech · Jul 28, 2023 · 4ac96fd · 4ac96fd
1 parent b0b520a
commit 4ac96fd
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/packages/shorebird_cli/lib/src/http_client/retrying_client.dart b/packages/shorebird_cli/lib/src/http_client/retrying_client.dart
@@ -12,6 +12,7 @@ http.Client retryingHttpClient(http.Client client) => RetryClient(
 
 bool isRetryableException(Object exception, StackTrace _) {
   return switch (exception.runtimeType) {
+    http.ClientException => true,
     HttpException => true,
     TlsException => true,
     SocketException => true,

diff --git a/packages/shorebird_cli/test/src/http_client/retrying_client_test.dart b/packages/shorebird_cli/test/src/http_client/retrying_client_test.dart
@@ -44,6 +44,13 @@ void main() {
         );
       });
 
+      test('returns true on http.ClientException', () {
+        expect(
+          isRetryableException(http.ClientException(''), StackTrace.empty),
+          isTrue,
+        );
+      });
+
       test('returns false on arbitrary exception', () {
         expect(isRetryableException(Exception(), StackTrace.empty), isFalse);
       });