Test coverage

shorebirdtech · Jan 8, 2025 · b2be080 · b2be080
1 parent 02edae1
commit b2be080
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/packages/shorebird_cli/lib/src/artifact_builder.dart b/packages/shorebird_cli/lib/src/artifact_builder.dart
@@ -561,16 +561,15 @@ Either run `flutter pub get` manually, or follow the steps in ${cannotRunInVSCod
         'build',
         'windows',
         '--release',
-        if (flavor != null) '--flavor=$flavor',
-        if (target != null) '--target=$target',
         ...args,
       ];
 
       final buildProcess = await process.start(
         executable,
         arguments,
         runInShell: true,
-        environment: base64PublicKey?.toPublicKeyEnv(),
+        // TODO(bryanoltman): support this
+        // environment: base64PublicKey?.toPublicKeyEnv(),
       );
 
       buildProcess.stdout

diff --git a/packages/shorebird_cli/test/src/commands/preview_command_test.dart b/packages/shorebird_cli/test/src/commands/preview_command_test.dart
@@ -1882,6 +1882,24 @@ channel: ${DeploymentTrack.staging.channel}
         });
       });
 
+      group('when downloading release artifact fails', () {
+        setUp(() {
+          when(
+            () => artifactManager.downloadFile(any()),
+          ).thenThrow(Exception('oops'));
+        });
+
+        test('returns code 70', () async {
+          final result = await runWithOverrides(command.run);
+          expect(result, equals(ExitCode.software.code));
+          verify(
+            () => artifactManager.downloadFile(
+              Uri.parse(releaseArtifactUrl),
+            ),
+          ).called(1);
+        });
+      });
+
       group('when preview artifact is not cached', () {
         setUp(() {
           when(() => artifactManager.downloadFile(any()))