-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(shorebird_cli): "SYS_KEYS has no physical keys" during preview #2646
Conversation
@@ -51,6 +51,7 @@ class Adb { | |||
if (deviceId != null) ...['-s', deviceId], | |||
'shell', | |||
'monkey', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm so confused why we're using monkey at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, I guess that's a known way. I'm used to historically sending an intent: https://www.repeato.app/launching-android-applications-via-adb/
"** SYS_KEYS has no physical keys but with factor 2.0%."
2836a36
to
244c537
Compare
It looks like tests are failing and cspell is unhappy. These should both be easy to fix. For cspell, you can add "syskeys" to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks so much for the contribution!
For context the reason you saw this error is most likely because you were trying to preview on an Android system which does not have hardware/physical system keys. |
"** SYS_KEYS has no physical keys but with factor 2.0%."
Description
When running preview, I got
Found https://stackoverflow.com/questions/44860475/how-to-use-the-monkey-command-with-an-android-system-that-doesnt-have-physical
Now it doesn't error.
But, I have no idea why I got it, or if this fix will cause other problems.
Type of Change