feat(shorebird_cli): add doctor check that lockfiles are tracked in source control #2738
+311
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
felangel
reviewed
Jan 3, 2025
packages/shorebird_cli/lib/src/validators/tracked_lock_files_validator.dart
Outdated
Show resolved
Hide resolved
felangel
approved these changes
Jan 3, 2025
…alidator.dart Co-authored-by: Felix Angelov <[email protected]>
felangel
reviewed
Jan 3, 2025
packages/shorebird_cli/test/src/validators/tracked_lock_files_validator_test.dart
Outdated
Show resolved
Hide resolved
felangel
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Warns if lockfiles are not tracked in source control. Untracked lockfiles are a common source of unexpected native changes/bad link percentages, and not all developers know they should track their lockfiles in source control.
This check will also warn if the project is not a git repo. We may want to remove this for our mercurial using customers.
Fixes #2734
Type of Change