feat: add support for macos on intel #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
bryanoltman
commented
Jan 24, 2025
| throw ArtifactBuildException('Failed to build: $stderr'); | ||
| throw ArtifactBuildException(''' | ||
| Failed to build | ||
| stdout: $stdout |
There was a problem hiding this comment.
stdout occasionally contains useful failure messages that are not included in stderr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switches macOS patch creation to use the simpler Android and Windows method of simply diffing the AOT snapshot against the release.
We still need to add validators to ensure that the correct app hardening settings are present in the macOS xcode project (specifically, if app hardening is enabled, that "allow unsigned executable memory" is checked):
I've verified with this that I can patch a mac release on both arm64 and intel machines, although there are some asset changes when using an intel mac to patch a release created on arm64.
Part of #2711
Type of Change