This repository has been archived by the owner on Oct 17, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 149
Emit errors through Search API #1000
Open
Coteh
wants to merge
13
commits into
master
Choose a base branch
from
search-error-handling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
5f92509
Emit errors through Search API
Coteh 3f99e4b
Run script formatter
Coteh 54918ef
Emit JSON from HTTP error, and emit appropriate status codes
Coteh 39d4dfe
Add tests
Coteh b2050c2
Improve search without user test
Coteh 0ed8474
Apply suggestions from code review
Coteh 3c74029
Apply suggestions from code review
Coteh 072ffd2
Fix typo with var declaration
Coteh 5c5f93d
Merge branch 'master' into search-error-handling
Coteh 09599a1
Add error channel for sending search errors
Coteh b3df329
Add documentation for search errors
Coteh 0073d1f
Fix search test
Coteh 54a7071
Merge branch 'master' into search-error-handling
Coteh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add error channel for sending search errors
- Also remove extra logging statement in searchShortLink
- Loading branch information
commit 09599a10badafe6e3f0458dee120526e1daf720e
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed based on the previous comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is still needed, because we would like to return only the first error that occurred. What do you think?