This repository has been archived by the owner on Oct 17, 2020. It is now read-only.
Add UpdateURL to graphql schema and resolvers #654
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicoder10
changed the title
magicoder10
reviewed
Apr 10, 2020
| @@ -20,6 +20,8 @@ type AuthQuery { | |||
|
|
|||
| type AuthMutation { | |||
| createURL(url: URLInput!, isPublic: Boolean!): URL | |||
| updateURL(alias: String!, url: URLInput!, isPublic: Boolean): URL | |||
There was a problem hiding this comment.
We'll have to discuss the isPublic parameter in the future.
magicoder10
approved these changes
Apr 10, 2020
|
Hi @oatovar , thank you very much for working on this feature! I think you need to add GraphQL schema with resolvers. Please resolve PR conflicts! |
magicoder10
suggested changes
Apr 10, 2020
|
@byliuyang thank you for the feedback. I will take a look at the resolvers and fix the PR conflicts. |
|
@oatovar I recommend we open PRs in the direction of dependency graph:
|
oatovar
changed the title
|
@byliuyang I went with the solution that you recommend in #239. Please let me know where I can improve. Thank you! |
* Add `URLUpdater` to url usecase * Update dependency injection and generated code * Update go module checksum
* Update UpdateURL args to satisfy schema changes. * Clean up code layout
* Update schema to allow flexible changes i.e. one field or multiple fields * Fix url `UPDATE` statement * Remove `external` package imports * Update dependency checksums
* Fix merge conflicts * Tidy up go.sum
* Reduce URL input types to one for reuse * Update CreateURL to use refactored URL input. * Cleanup update creation so that it only runs at one level of abstraction. * Update `wire_gen.go`
|
Closing and making new PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update GraphQL Schema's AuthMutation to include
updateURL.Refactor to use single
UrlInputin bothupdateURLandcreateURL.Regenerate wired dependencies.