Skip to content
This repository has been archived by the owner on Oct 17, 2020. It is now read-only.

Add Tabbed layout #732

Closed
wants to merge 4 commits into from
Closed

Add Tabbed layout #732

wants to merge 4 commits into from

Conversation

rohithbalaji123
Copy link
Member

@rohithbalaji123 rohithbalaji123 commented May 2, 2020 •
edited
Loading

Part of #612

Description

Add a generic tabbed layout component.

Screenshots

image

ToDo:

  • Add tests

@rohithbalaji123 rohithbalaji123 self-assigned this May 2, 2020
@codecov
Copy link

codecov bot commented May 2, 2020 •
edited
Loading

Codecov Report

Merging #732 into master will increase coverage by 0.44%.
The diff coverage is 89.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #732      +/-   ##
==========================================
+ Coverage   52.83%   53.28%   +0.44%     
==========================================
  Files         110      111       +1     
  Lines        2258     2286      +28     
  Branches      130      134       +4     
==========================================
+ Hits         1193     1218      +25     
- Misses       1023     1026       +3     
  Partials       42       42
Flag Coverage Δ
#golang 74.84% <ø> (ø)
#typescript 26.61% <89.28%> (+1.76%) ⬆️
Impacted Files Coverage Δ
frontend/src/component/layouts/TabbedLayout.tsx 89.28% <89.28%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cf77bb...771766b. Read the comment docs.

@pull-request-size pull-request-size bot added size/M and removed size/L labels May 2, 2020
@magicoder10 magicoder10 added this to the 05/02 - 05/08 milestone May 2, 2020
@pull-request-size pull-request-size bot added size/L and removed size/M labels May 3, 2020
@rohithbalaji123 rohithbalaji123 marked this pull request as ready for review May 3, 2020 18:34
magicoder10
magicoder10 suggested changes May 3, 2020
View reviewed changes
frontend/src/component/layouts/TabbedLayout.scss
Comment on lines +8 to +10
.tab-headers {
flex: 0 0;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove this and leave tab content creators to decide whatever they want to do.

frontend/src/component/layouts/TabbedLayout.tsx
@@ -0,0 +1,81 @@
import React, { Component, ReactChild } from 'react';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think tab layout is more like this: https://material.angular.io/components/tabs/overview
This component has drawer. I am not sure whether it qualifies for tab component. I recommend directly put them inside admin page.

What are your thoughts on this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, I recommend closing this PR and create an empty admin page PR instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, got it!

@rohithbalaji123 rohithbalaji123 deleted the tabbed-layout branch May 8, 2020 13:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@magicoder10 magicoder10 magicoder10 requested changes

Assignees

@rohithbalaji123 rohithbalaji123

Labels
size/L
Projects
None yet
Milestone
05/02 - 05/10
Development

Successfully merging this pull request may close these issues.
2 participants
@rohithbalaji123 @magicoder10