Skip to content
This repository has been archived by the owner on Oct 17, 2020. It is now read-only.

Add tabs component #749

Merged
merged 3 commits into from
May 8, 2020
Merged

Add tabs component #749

merged 3 commits into from
May 8, 2020

Conversation

rohithbalaji123
Copy link
Member

Part of #612

New Behavior

Description

Add Tabs component which can be handy when there a set of pages of which one should be shown at a time and rendering should be controlled with the index of the pages.

Screenshots

image

@rohithbalaji123 rohithbalaji123 added the enhancement New feature or request label May 8, 2020
@rohithbalaji123 rohithbalaji123 self-assigned this May 8, 2020
@pull-request-size pull-request-size bot added size/L and removed size/M labels May 8, 2020
frontend/src/component/ui/Tabs.spec.tsx Outdated Show resolved Hide resolved
frontend/src/component/ui/Tabs.spec.tsx Outdated Show resolved Hide resolved
frontend/src/component/ui/Tabs.spec.tsx Outdated Show resolved Hide resolved
frontend/src/component/ui/Tabs.spec.tsx Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #749 into master will decrease coverage by 26.41%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #749       +/-   ##
===========================================
- Coverage   53.14%   26.73%   -26.42%     
===========================================
  Files         112       65       -47     
  Lines        2271     1010     -1261     
  Branches      129      132        +3     
===========================================
- Hits         1207      270      -937     
+ Misses       1022      740      -282     
+ Partials       42        0       -42     
Flag Coverage Δ
#golang ?
#typescript 26.73% <100.00%> (+1.25%) ⬆️
Impacted Files Coverage Δ
frontend/src/component/ui/Tabs.tsx 100.00% <100.00%> (ø)
backend/app/adapter/google/api.go
backend/app/adapter/sqldb/bool.go
backend/app/usecase/validator/longlink.go
backend/app/adapter/github/account.go
backend/app/adapter/google/identityprovider.go
backend/app/adapter/gqlapi/resolver/viewer.go
backend/app/adapter/sqldb/url.go
backend/app/adapter/gqlapi/resolver/change.go
backend/app/usecase/keygen/keygen.go
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e370f7...4c6317a. Read the comment docs.

@magicoder10 magicoder10 added this to the 05/02 - 05/08 milestone May 8, 2020
@magicoder10 magicoder10 merged commit 222fdbc into master May 8, 2020
@magicoder10 magicoder10 deleted the tabs-comp branch May 8, 2020 16:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants