Skip to content
This repository has been archived by the owner on Oct 17, 2020. It is now read-only.

Separate out withFeatureToggle HOC component #817

Merged
merged 1 commit into from
May 26, 2020
Merged

Conversation

rohithbalaji123
Copy link
Member

@rohithbalaji123 rohithbalaji123 commented May 26, 2020

Part of #612

Current Behavior ( Optional for new feature )

Description

Implementation for withFeatureToggle lies within UIFactory. With more higher order components getting into the project, it's better we separate the building HOC logic in a separate file and focus only on building UI components in UIFactory

New Behavior

Description

Created a new directory called hoc inside components and added withFeatureToogle there.

@rohithbalaji123 rohithbalaji123 added the refactor Refactors code without logical change label May 26, 2020
@rohithbalaji123 rohithbalaji123 self-assigned this May 26, 2020
@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #817 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #817   +/-   ##
=======================================
  Coverage   50.31%   50.31%           
=======================================
  Files         121      122    +1     
  Lines        2564     2564           
  Branches      143      143           
=======================================
  Hits         1290     1290           
  Misses       1224     1224           
  Partials       50       50           
Flag Coverage Δ
#golang 70.45% <ø> (ø)
#typescript 24.42% <0.00%> (ø)
Impacted Files Coverage Δ
frontend/src/component/UIFactory.tsx 0.00% <ø> (ø)
frontend/src/component/hoc/withFeatureToggle.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e05baeb...eff2abc. Read the comment docs.

@magicoder10 magicoder10 merged commit 58d0da9 into master May 26, 2020
@magicoder10 magicoder10 deleted the feature-hoc branch May 26, 2020 19:07
@magicoder10 magicoder10 added this to the 05/25 - 06-01 milestone May 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactor Refactors code without logical change size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants