This repository has been archived by the owner on Oct 17, 2020. It is now read-only.
Add Auth HOC to wrap authorized pages #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #818 +/- ##
==========================================
- Coverage 50.31% 49.82% -0.49%
==========================================
Files 122 123 +1
Lines 2564 2589 +25
Branches 143 147 +4
==========================================
Hits 1290 1290
- Misses 1224 1249 +25
Partials 50 50
Continue to review full report at Codecov.
|
magicoder10
suggested changes
May 27, 2020
|
Please address the small comment I left. |
magicoder10
approved these changes
May 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #612
New Behavior
Description
Add
withPageAuthHOC to wrap auth protected pages. It currently returns a 404 page when the user isn't authorized to view the page and displays the wrapped page if authorized.