This repository has been archived by the owner on Oct 17, 2020. It is now read-only.
Make feature toggle decision at mount time instead of build time #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicoder10
suggested changes
Jun 3, 2020
Codecov Report
@@ Coverage Diff @@
## master #827 +/- ##
=======================================
Coverage 50.03% 50.03%
=======================================
Files 123 123
Lines 2650 2650
Branches 147 147
=======================================
Hits 1326 1326
Misses 1274 1274
Partials 50 50
Continue to review full report at Codecov.
|
magicoder10
approved these changes
Jun 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #612
Current Behavior ( Optional for new feature )
Description
The feature toggle and auth toggle decision is currently being made in constructor of UIFactory making it happen only once during the initial setup unless the page is reloaded. With the current dynamic(auth based) feature toggle functionality in place, this won't work as users will keep alternating between logged in and out state. That is, when a user is initially logged out, the permission based features will be unavailable and it will continue to be unavailable even after logging in.
New Behavior
Description
Instead of passing the decision(
Promise<bool>) in thewithFeatureToggleandwithPageAuthHOCs, we pass the decision maker so that it can be called while mounting the component and thus satisfying the dynamicity.