This repository has been archived by the owner on Oct 17, 2020. It is now read-only.
Add create change service APIs #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #900 +/- ##
==========================================
- Coverage 53.17% 52.74% -0.44%
==========================================
Files 133 133
Lines 3180 3206 +26
Branches 153 156 +3
==========================================
Hits 1691 1691
- Misses 1421 1447 +26
Partials 68 68
Continue to review full report at Codecov.
|
magicoder10
suggested changes
Jun 27, 2020
There was a problem hiding this comment.
Hi @rohithbalaji123 , thank you so much for working on this cool feature! I left few comments on the PR. Please check them out!
magicoder10
approved these changes
Jun 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #612
New Behavior
Description
Add service methods to create a new change.
I have tried to split the=> Reverting back to previous style.createChangemethod inChangeGraphQLApiinto multiple methods with each focusing on only one thing. Please confirm if the approach is alright.