-
Notifications
You must be signed in to change notification settings - Fork 149
Conversation
Codecov Report
@@ Coverage Diff @@
## master #905 +/- ##
==========================================
- Coverage 52.40% 52.26% -0.14%
==========================================
Files 133 133
Lines 3227 3249 +22
Branches 157 157
==========================================
+ Hits 1691 1698 +7
- Misses 1468 1482 +14
- Partials 68 69 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rohithbalaji123! Thank you for working on this! Left a few small comments.
@rohithbalaji123 GraphQL client side query can decide which fields to fetch and ignore those that are not needed. |
The reason why I went for a new API is that they are being used for completely different purposes and their fetching mechanism might change in future. |
Part of #612
New Behavior
Description
Add
changes
graphQL API to fetch all the changes available to be displayed in admin panel. This is different fromchangeLog
in the sense that,changeLog
also fetcheslastViewedAt
timestamp which is not related to admin panel functionalities. The newly added API internally reuses the same repository methods used forchangeLog
. This also adds the permission check whether the user can view the changes.