Skip to content
This repository has been archived by the owner on Oct 17, 2020. It is now read-only.

Add textarea form component #931

Merged
merged 5 commits into from
Jul 6, 2020
Merged

Add textarea form component #931

merged 5 commits into from
Jul 6, 2020

Conversation

rohithbalaji123
Copy link
Member

Part of #612

New Behavior

Description

Add a textarea form field to allow users to input multiple lines.

Screenshots

image

@rohithbalaji123 rohithbalaji123 added the enhancement New feature or request label Jul 5, 2020
@rohithbalaji123 rohithbalaji123 self-assigned this Jul 5, 2020
@codecov
Copy link

codecov bot commented Jul 5, 2020

Codecov Report

Merging #931 into master will increase coverage by 30.14%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #931       +/-   ##
===========================================
+ Coverage   22.87%   53.02%   +30.14%     
===========================================
  Files          73      137       +64     
  Lines        1307     3389     +2082     
  Branches      164      165        +1     
===========================================
+ Hits          299     1797     +1498     
- Misses       1008     1529      +521     
- Partials        0       63       +63     
Flag Coverage Δ
#golang 71.91% <ø> (?)
#typescript 23.15% <83.33%> (+0.27%) ⬆️
Impacted Files Coverage Δ
frontend/src/component/form/TextAreaField.tsx 83.33% <83.33%> (ø)
backend/app/adapter/gqlapi/resolver/viewer.go 0.00% <0.00%> (ø)
backend/app/adapter/gqlapi/resolver/change.go 0.00% <0.00%> (ø)
backend/app/adapter/sqldb/facebooksso.go 56.86% <0.00%> (ø)
backend/app/adapter/gqlapi/resolver/authquery.go 31.11% <0.00%> (ø)
backend/app/usecase/sso/identityprovider_fake.go 75.00% <0.00%> (ø)
backend/app/usecase/shortlink/retriever.go 92.59% <0.00%> (ø)
backend/app/adapter/sqldb/time.go 100.00% <0.00%> (ø)
backend/app/adapter/sqldb/user_changelog.go 92.85% <0.00%> (ø)
backend/app/adapter/google/account.go 100.00% <0.00%> (ø)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25cc4de...778a378. Read the comment docs.

Copy link
Member

@magicoder10 magicoder10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we should add automated test for this one.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 6, 2020
@rohithbalaji123 rohithbalaji123 merged commit 4a95e56 into master Jul 6, 2020
@rohithbalaji123 rohithbalaji123 deleted the TextArea-comp branch July 6, 2020 06:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants