Skip to content
This repository has been archived by the owner on Oct 17, 2020. It is now read-only.

Upgrade to Storybook 6 #996

Merged
merged 6 commits into from
Aug 20, 2020
Merged

Upgrade to Storybook 6 #996

merged 6 commits into from
Aug 20, 2020

Conversation

Coteh
Copy link
Collaborator

@Coteh Coteh commented Aug 16, 2020

There's some breaking changes and deprecations that I'm still sorting out so leaving this in draft for now.

Using this guide: https://medium.com/storybookjs/storybook-6-migration-guide-200346241bb5

Remaining items to be done in #998

Checklist:

  • Remove withKnobs decorator since it's now baked in with its preset (source)
  • Remove TypeScript configuration since there's now a baked in default (source)
  • Switch addons-info, which is now deprecated, to addons-docs (source)
  • Consider switching addons-knobs to Storybook Controls
  • Convert story items to use Storybook Args (source)
  • Ensure everything else from Migrations guide is checked off
  • Consider adding MDX documentation to stories (should probably make this a separate issue that can be dealt with later, since it's more of a nice-to-have) (source)
  • Bump to 6.0.12
  • Bump to newest minor version before pushing

@codecov
Copy link

codecov bot commented Aug 16, 2020

Codecov Report

Merging #996 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #996   +/-   ##
=======================================
  Coverage   52.58%   52.58%           
=======================================
  Files         142      142           
  Lines        3564     3564           
  Branches      168      168           
=======================================
  Hits         1874     1874           
  Misses       1623     1623           
  Partials       67       67           
Flag Coverage Δ
#golang 72.03% <ø> (ø)
#typescript 22.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56b9f46...773fd48. Read the comment docs.

@magicoder10 magicoder10 marked this pull request as ready for review August 17, 2020 05:43
story/.storybook/main.js Outdated Show resolved Hide resolved
story/src/0-Button.stories.tsx Show resolved Hide resolved
@magicoder10 magicoder10 merged commit 3c79963 into master Aug 20, 2020
@magicoder10 magicoder10 deleted the upgrade-storybook branch August 20, 2020 03:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants