Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making all signal connections use partials rather than lambdas to wor… #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Liametc
Copy link

@Liametc Liametc commented Jun 5, 2019

…k with katana

In katana, signals that are connected to lambdas return booleans rather than the desired objects. Using partials fixes this behaviour

@Liametc
Copy link
Author

Liametc commented Nov 18, 2019

@pscadding tagging you (again, sorry) to also get this logged. Goes with this PR as part of getting shotgun into Katana

@pscadding pscadding added the Logged Logged in Jira label Nov 19, 2019
@pscadding
Copy link
Contributor

No problem I've logged this one as well, thanks!

@swc-jesse
Copy link

swc-jesse commented Oct 6, 2021

This PR seems to be required to get these signal connections working at all. For example, using the app store version of multi-loader2 in Maya or on the Desktop gives this error, which is resolved by this PR:

File "S:\Projects\ShotgunConfig\tk-multi-loader2\python\tk_multi_loader\loader_action_manager.py", line 378, in <lambda> sg.triggered[()].connect(lambda f=sg_data: self._show_in_sg(f)) File "S:\Projects\ShotgunConfig\tk-multi-loader2\python\tk_multi_loader\loader_action_manager.py", line 478, in _show_in_sg entity["type"], TypeError: 'bool' object is not subscriptable

Is anyone else seeing this? Should it be integrated into the App Store version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Logged Logged in Jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants