Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A refactor I've been thinking about to eliminate the aws-sdk dependencies to save us from our terrible build times.
Still a long way way to go so I think I'll just work around the issue for now.Ended up finishing it off.
The code quality is poor in some places as I'm hoping to delete this if the aws-sdk team can fix the build times, which they have promised to try
So on one hand this PR cuts out 5 minutes from an uncached release build.
But it also only cuts out 20 seconds from a cached release build and I was expecting to cut out a lot more (currently our cached release builds take 3 minutes)
I think it still makes sense to land at this point, although maybe I should have invested my time elsewhere in the first place.