Allow user to restrict ingress rules #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
restrict_ingress
branch
3 times, most recently
from
0504dcb to
d363799
Compare
ronycsdu
approved these changes
Sep 27, 2024
rukai
force-pushed
the
restrict_ingress
branch
from
d363799 to
ac17c5c
Compare
justinweng-instaclustr
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable support in certain corporate environments that disallow ingress of
0.0.0.0/0, this PR adds a config option, disabled by default, to fetch the public IP of the user and set the ingress rules to that IP specifically.Maybe
IngressRestriction::LocalPublicAddressshould become the default in the future but for now I've made it disabled by default so that this can remain a non-breaking change.reminder of aws-throwaway internals:
We still duplicate a bunch of logic across the CLI and SDK backend, in the hope that the SDK backend fixes its compile time issues and becomes usable in shotover again.
I have tested the new functionality on both backends.
license_check.yaml changes fix broken CI because we didnt pin the version of cargo-deny we use