Remove TestContext and improve test connection handling #143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #133 (sorry connor 😢 )
I changed the retry logic to just check if we can create a simple TCP socket.
This drastically reduces the complexity and should also allow the check to work for both regular and TLS connections.
I changed the retry timeout from an increasing timeout to a regular 100ms timeout, this makes more sense to me as we want the test to finish as soon as possible and dont need to worry about overwhelming production systems with too many retries.
I opted to move the FLUSHDB into the test cases that need it.
My reasoning is:
An alternative to adding FLUSHDB's around is to create an
fn run_sub_test_case(&[Func], connection: &mut Connection)
that runs FLUSHDB before running each test case. But I think it would be simpler not to do that.This is a prereq to #141 as I will need to add an
fn redis_connection_tls
to ShotoverManager and I also need to be able to call the test cases with an arbitrary redis::Connection.