Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

":" is not a valid character for files/folders on Windows #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

throttlekitty
Copy link

No description provided.

@kadirnar
Copy link

Thanks it worked for me 🚀

@@ -106,6 +106,7 @@ def parse_args(input_args=None):

def run_inference(args):
current_datetime = datetime.datetime.now()
current_datetime = str(current_datetime).replace(":", "_")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
current_datetime = str(current_datetime).replace(":", "_")
if os.name == 'nt':
current_datetime = str(current_datetime).replace(":", "_")

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks.

Copy link

@light-and-ray light-and-ray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's specific for windows, it's better it check if os is windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants