Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

[WIP] Add React Three Fiber #704

Merged
merged 22 commits into from
Apr 13, 2022
Merged

[WIP] Add React Three Fiber #704

merged 22 commits into from
Apr 13, 2022

Conversation

axeldelafosse
Copy link
Contributor

@axeldelafosse axeldelafosse commented Jan 18, 2022

Note

Marc and Cody are still working on r3f support for React Native. We made some changes here that needs to be merged into staging. Leaving this tagged as a WIP but merging anyway. We might want to work on 3D models on web very soon

Why

This PR adds r3f so we can display 3D models in the native app

How

  • Install r3f
  • Prepare the native app for 3D models support
  • Fix Storybook React Native

@vercel
Copy link

vercel bot commented Jan 18, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/showtime/showtime/5YupNt79gsHoHJgVU6AivRphwhWB
✅ Preview: https://showtime-git-3d-models-showtime.vercel.app

[Deployment for cc8bbeb failed]

@github-actions
Copy link

github-actions bot commented Jan 18, 2022

PR Preview - Storybook

This pull request preview deployment is now available.

✅ Preview: exp+io.showtime.storybook://expo-development-client/?url=https://u.expo.dev/e77d5b68-bb27-45da-aa5c-96c1fdbf6706&channel-name=pr-704

Comment ID: 1015436092

@github-actions
Copy link

github-actions bot commented Jan 18, 2022

PR Preview - App

This pull request preview deployment is now available.

✅ Preview: exp+io.showtime.development://expo-development-client/?url=https://u.expo.dev/45cbf5d5-24fe-4aa6-9580-acf540651abd&channel-name=pr-704

Comment ID: 1015440296

@github-actions
Copy link

github-actions bot commented Jan 18, 2022

PR Preview - Storybook on Chromatic

✅ Preview: The Storybook preview URL for this Pull Request

✅ Build: The Chromatic build URL for this Pull Request

@vercel
Copy link

vercel bot commented Jan 21, 2022

@mrousavy is attempting to deploy a commit to the Showtime Team on Vercel.

To accomplish this, @mrousavy needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@vercel
Copy link

vercel bot commented Jan 31, 2022

An owner of the Showtime Team on Vercel declined @mrousavy's request to join.

In order for their commit to be deployed, @mrousavy must push and request access again.

@axeldelafosse axeldelafosse changed the title Add React Three Fiber [WIP] Add React Three Fiber Feb 1, 2022
@axeldelafosse axeldelafosse marked this pull request as ready for review April 13, 2022 12:38
@axeldelafosse axeldelafosse merged commit 3951cd1 into staging Apr 13, 2022
@axeldelafosse axeldelafosse deleted the 3d-models branch May 3, 2022 13:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants