Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added remove link button to link summary screen. #408

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

Dorus
Copy link
Collaborator

@Dorus Dorus commented Feb 7, 2025

A list of nice-to-have things:

afbeelding

@Dorus Dorus requested a review from shpaass as a code owner February 7, 2025 09:29
@shpaass shpaass requested a review from DaleStan February 7, 2025 09:34
@Dorus Dorus force-pushed the link-summary-remove branch from 871be9c to d1e8d8f Compare February 10, 2025 20:09
@Dorus Dorus force-pushed the link-summary-remove branch from d1e8d8f to e183283 Compare February 10, 2025 20:09
@Dorus Dorus mentioned this pull request Feb 12, 2025
3 tasks
@shpaass shpaass merged commit f3b0e97 into shpaass:master Feb 13, 2025
1 check passed
shpaass added a commit that referenced this pull request Feb 20, 2025
A list of nice-to-have things:
* [x] A changelog 
* [ ] The link from the PR to the issue that it fixes. -> Not a direct
fix, but this is work towards better link visualization to aid #409,
#414
* [x] A description of what testing was done.
I clicked around on the new unrelated links and you navigate to new
links from there.

As a followup to #408 this is an implementation of #414 (Only the
visualization part):


![afbeelding](https://github.com/user-attachments/assets/bef76af3-ded1-4f2c-b290-dca8d76346f2)

As seen above, the link summary now not only display the currently
selected link, but also recipes from other links covering the same
recipe. It also tells you where in the recipe tree those links are,
parent means they're in the same branch but higher up, child means the
same but lower, unrelated is any other recipe.

There are a few more unimplemented ideas in #414 to add buttons to
manipulate the other recipes, those can be tackled later.


![afbeelding](https://github.com/user-attachments/assets/2a2b592b-b68a-4b8a-b26e-667113464c79)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants