-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quality recipes #417
Quality recipes #417
Conversation
The ability to pass a bogus quality parameter (e.g. rare fluids) and have it ignored will later prove to be helpful.
The solver still assumes all products are normal, though.
Wow, that's a huge feature. This is awesome! We need to check that Yafc still works with usual mod-lists.
Again, thank you for all the effort you put into Yafc! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely split into the separate commits, helps a lot in understand your (thought) steps
(I didn't start YAFC up to try it)
I had to make a couple fixes for Infinite Quality Tiers and No More Gambling hasn't loaded since 2.2.0. Otherwise it looks good to me in Vanilla, Omni, py, and pyhm. |
These changes allow Yafc to calculate production with quality bonuses and quality input items. Recipes and Items now have quality levels. Several other objects such as Mechanics and Fluids pretend to have quality levels for compatibility, but only ever exist in normal quality.
It covers two of the remaining four tasks in #311, leaving out
fixed_quality
and quality science packs. Properly consuming quality science packs is next on my list, but they are being obstinate.Quality modules only produce qualities that are unlocked based on the selected milestones. To make this more discoverable, there is also a new warning message telling the user to "Make sure ... all milestones for the next quality are unlocked." I considered, but later removed, additional code that adds all non-normal qualities as default milestones. If we want to add more default milestones, I can put it back.
I used this project for testing and to trial various possible answers to my most pressing question about quality bonuses, namely: How do I maximize the output of legendary prod 3 modules from a single captive spawner?