Fix saving legacy summaries #423
Open
+491
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add tests to help ensure all apparently serializable types remain serializable.
shpaass
approved these changes
Feb 24, 2025
veger
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in Discord, the legacy summary page cannot be saved.
I broke the serialization rules, and I don't think it's the first time, so I also added some tests to watch the serializable types and complain when they change and/or are out of compliance.
SerializationTreeChangeDetection.TreeHasNotChangedmight turn out to be too aggressive, but it seemed like a good idea.