Merge pull request kubernetes-sigs#3864 from shraddhabang/main

GO2 SDK Migration bug fix on comparators
shraddhabang · Sep 26, 2024 · 84a8cf7 · 84a8cf7
2 parents 6965e9d + 9bced78
commit 84a8cf7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/pkg/equality/elbv2/compare_option_for_actions.go b/pkg/equality/elbv2/compare_option_for_actions.go
@@ -30,6 +30,7 @@ func CompareOptionForForwardActionConfig() cmp.Option {
 	return cmp.Options{
 		equality.IgnoreLeftHandUnset(elbv2types.ForwardActionConfig{}, "TargetGroupStickinessConfig"),
 		cmpopts.IgnoreUnexported(elbv2types.ForwardActionConfig{}),
+		cmpopts.IgnoreUnexported(elbv2types.TargetGroupStickinessConfig{}),
 		CompareOptionForTargetGroupTuples(),
 	}
 }

diff --git a/pkg/equality/elbv2/compare_option_for_rule_conditions.go b/pkg/equality/elbv2/compare_option_for_rule_conditions.go
@@ -11,9 +11,11 @@ func CompareOptionForRuleCondition() cmp.Option {
 	return cmp.Options{
 		cmpopts.IgnoreUnexported(elbv2types.RuleCondition{}),
 		cmpopts.IgnoreUnexported(elbv2types.HostHeaderConditionConfig{}),
+		cmpopts.IgnoreUnexported(elbv2types.HttpHeaderConditionConfig{}),
 		cmpopts.IgnoreUnexported(elbv2types.HttpRequestMethodConditionConfig{}),
 		cmpopts.IgnoreUnexported(elbv2types.PathPatternConditionConfig{}),
 		cmpopts.IgnoreUnexported(elbv2types.QueryStringConditionConfig{}),
+		cmpopts.IgnoreUnexported(elbv2types.QueryStringKeyValuePair{}),
 		cmpopts.IgnoreUnexported(elbv2types.SourceIpConditionConfig{}),
 		cmpopts.IgnoreFields(elbv2types.RuleCondition{}, "Values"),
 	}