feat(chart) : add RuntimeClassName (kubernetes-sigs#3646)

* add RuntimeClassName * fixed /test pull-aws-load-balancer-controller-e2e-test * fixed helm syntax error * fixed Conflicting files
shraddhabang · May 2, 2024 · b44633a · b44633a
1 parent 4ffee8d
commit b44633a
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 1 deletion.
diff --git a/helm/aws-load-balancer-controller/README.md b/helm/aws-load-balancer-controller/README.md
@@ -178,6 +178,7 @@ Chart release v1.2.0 and later enables high availability configuration by defaul
 The following tables lists the configurable parameters of the chart and their default values.
 The default values set by the application itself can be confirmed [here](https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.4/deploy/configurations/#controller-configuration-options).
 
+
 | Parameter                                      | Description                                                                                                                                                                                                            | Default                                           |
 |------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------------------------------------------|
 | `image.repository`                             | image repository                                                                                                                                                                                                       | `public.ecr.aws/eks/aws-load-balancer-controller` |
@@ -272,4 +273,5 @@ The default values set by the application itself can be confirmed [here](https:/
 | `serviceMutatorWebhookConfig.operations`       | List of operations that will trigger the the Service Mutator webhook                                                                                                                                                   | `[ CREATE ]`                                      |
 | `autoscaling`                 | If `autoscaling.enabled=true`, enable the HPA on the controller mainly to survive load induced failure by the calls to the `aws-load-balancer-webhook-service`. Please keep in mind that the controller pods have `priorityClassName: system-cluster-critical`, enabling HPA may lead to the eviction of other low-priority pods in the node                                                                                                                                              | `false`                                           |
 | `serviceTargetENISGTags`                 | set of `key=value` pairs of AWS tags in addition to cluster name for finding the target ENI security group to which to add inbound rules from NLBs                                                                                                                                            | None                                          |
-| `loadBalancerClass`                   | Sets the AWS load balancer type to be used when the Kubernetes service requests an external load balancer                                                                                                                       | `service.k8s.aws/nlb`                                           |
+| `loadBalancerClass`                   | Sets the AWS load balancer type to be used when the Kubernetes service requests an external load balancer                                                                                                                       | `service.k8s.aws/nlb`                                           |
+| `runtimeClassName`                 | Runtime class name for the controller pods , such as `gvisor` or `kata`. An unspecified `nil` or empty `""` RuntimeClassName is equivalent to the backwards-compatible default behavior as if the RuntimeClass feature is disabled.                                                                                                                      | ""                                                | 
diff --git a/helm/aws-load-balancer-controller/templates/deployment.yaml b/helm/aws-load-balancer-controller/templates/deployment.yaml
@@ -38,6 +38,9 @@ spec:
     {{- with .Values.imagePullSecrets }}
       imagePullSecrets:
         {{- toYaml . | nindent 8 }}
+    {{- end }}
+    {{- with .Values.runtimeClassName }}
+      runtimeClassName: {{ .Values.runtimeClassName }}
     {{- end }}
       serviceAccountName: {{ include "aws-load-balancer-controller.serviceAccountName" . }}
       volumes:

diff --git a/helm/aws-load-balancer-controller/test.yaml b/helm/aws-load-balancer-controller/test.yaml
@@ -12,6 +12,7 @@ image:
 imagePullSecrets: []
 nameOverride: ""
 fullnameOverride: ""
+runtimeClassName: ""
 
 serviceAccount:
   # Specifies whether a service account should be created

diff --git a/helm/aws-load-balancer-controller/values.yaml b/helm/aws-load-balancer-controller/values.yaml
@@ -11,6 +11,7 @@ image:
   tag: v2.7.0
   pullPolicy: IfNotPresent
 
+runtimeClassName: ""
 imagePullSecrets: []
 nameOverride: ""
 fullnameOverride: ""