Added a config option to set the permit list size for esp32 traces

- Fixes project-chip#31536
shripad621git · Feb 14, 2024 · b2f77b3 · b2f77b3
1 parent 67f2ae5
commit b2f77b3
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/config/esp32/components/chip/Kconfig b/config/esp32/components/chip/Kconfig
@@ -912,6 +912,12 @@ menu "CHIP Device Layer"
            default n
            help
                This option enables the system statistics to be sent to the insights cloud.
+
+      config INSIGHTS_TRACE_PERMIT_LIST_SIZE
+           int "Config option to set permitlist size"
+           range 5 30
+           depends on ESP_INSIGHTS_ENABLED
+           default 20
     endmenu
 
 

diff --git a/src/tracing/esp32_trace/counter.h b/src/tracing/esp32_trace/counter.h
@@ -24,8 +24,7 @@
 
 namespace Insights {
 
-/*
- *
+/**
  * This class is used to monotonically increment the counters as per the label of the counter macro
  * 'MATTER_TRACE_COUNTER(label)' and report the metrics to esp-insights.
  * As per the label of the counter macro, it adds the counter in the linked list with the name label if not
@@ -37,7 +36,7 @@ class ESPInsightsCounter
 {
 private:
     static ESPInsightsCounter * mHead; // head of the counter list
-    const char * label;                // unique key
+    const char * label;                // unique key ,it is used as a static string.
     int instanceCount;
     ESPInsightsCounter * mNext; // pointer to point to the next entry in the list
     bool registered = false;

diff --git a/src/tracing/esp32_trace/esp32_tracing.cpp b/src/tracing/esp32_trace/esp32_tracing.cpp
@@ -30,7 +30,7 @@ namespace Tracing {
 namespace Insights {
 namespace {
 
-constexpr size_t kPermitListMaxSize = 20;
+constexpr size_t kPermitListMaxSize = CONFIG_INSIGHTS_TRACE_PERMIT_LIST_SIZE;
 using HashValue                     = uint32_t;
 
 // Implements a murmurhash with 0 seed.