chore: move ApiKey type to backends, remove AccountTier sqlx::Type #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jonaro00
commented
Nov 26, 2024
jonaro00
commented
- debloats common
- prevents mistake of binding an AccountTier and db not finding the type
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR moves the ApiKey type from common to backends module and removes AccountTier's sqlx::Type derivation to reduce common module bloat and prevent database type binding issues.
- Relocated ApiKey implementation to
backends/src/key.rswith proper validation for 16-char alphanumeric keys and secure memory handling via zeroize - Removed
#[cfg_attr(feature = "persist", derive(sqlx::Type))]fromcommon/src/models/user.rsto prevent direct AccountTier database bindings - Updated import paths across codebase to use
shuttle_backends::key::ApiKeyinstead of from common module
11 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+22
to
+25
| let mut errors = vec![]; | ||
| if !key.chars().all(char::is_alphanumeric) { | ||
| errors.push("The API key should consist of only alphanumeric characters."); | ||
| }; |
There was a problem hiding this comment.
syntax: unnecessary semicolon after if block creates unreachable code
| @@ -68,12 +67,8 @@ extract_propagation = [ | |||
| "tracing-opentelemetry", | |||
| ] | |||
| models = ["async-trait", "reqwest", "service"] | |||
There was a problem hiding this comment.
style: models feature still depends on service feature but service feature depends on display - consider flattening these dependencies to avoid circular references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.