fix: ignorable errors should not affect react refresh #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
perf: 一些无关紧要的错误应该被忽略，比如 error-overlay 这里对没有错误堆栈的 error 有 if 条件判断拦截，故不会通过弹窗的形式透出给用户。
而热更新 hotDevClient 这里没有上面的 if 条件判断拦截，导致用户感知不到错误发生的情况下页面直接 location.reload 而不是 ReactRefresh 热更新
Did you add tests(unit,e2e) for your changes?
no
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
no