Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use working directory of exec #16

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StefanSchoof
Copy link
Contributor

I have a monorepro, where my frontend is the folder frontend and only this is using eslint. I updated my .eslintrc.yml to support multiple projects:

parserOptions:
  project:
    - tsconfig.json
    - tsconfig.node.json

eslint is searching for this files relative to the working directory and not relative to the eslintrc, see typescript-eslint/typescript-eslint#540. So with a project files and in a sub folder this action does not work.

I get this to work with setting the working dir (cwd) of the exec command. But this would be a breaking change for this action. I see multiple options:

  • Do not support project folder option of eslint
  • Make a breaking change and a new major version (There are more places that needs changing, eg. the path.ts)
  • Add a extra input to control the cwdof the exec

@sibiraj-s
Copy link
Owner

Hi, Thanks for the PR. Yeah it would be great to get this fixed.

@StefanSchoof
Copy link
Contributor Author

So your wish is, that this gets fixed with a breaking change?

@stalkerg
Copy link

I have the same issue, any updates?

@sibiraj-s
Copy link
Owner

Sorry I missed this one. Yes @StefanSchoof its okay if there is a breaking change, unless no functionalities are removed.

I am happy to get this merged and publish a new major. @StefanSchoof are there any more pending changes?

@stalkerg
Copy link

@sibiraj-s base on changes, it's doesn't remove any functionalities but now your .node_modules should be in work_dir folder. It's basically what I expected as well, but maybe some people can have issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants