Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: getSession force refetch option #425

Merged

Conversation

LouisHaftmann
Copy link
Contributor

Adds a force option to getSession. Useful when token cookie has been updated by an external api route (not handled by nuxt-auth's signIn/signOut) because the token in useAuthState would still be undefined/null after manually calling a register api route for example.

Copy link
Contributor

@BracketJohn BracketJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution ❤️ Please also extend the docs with the new config option and we are good to go (:

Copy link
Contributor

@BracketJohn BracketJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there:

  • I should've let you know: You have to change the docs of v0.6 as this is the version that will receive this feature. They are located at docs/v0.6/ - can you move your changes there?
  • your changes only effect the local-provider - when you move your doc-changes to the docs/v0.6 part, it should also be clearer, that this is the case

Copy link
Member

@zoey-kaiser zoey-kaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoey-kaiser zoey-kaiser merged commit e2ea743 into sidebase:main Sep 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants