Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

globalAppMiddleware: true behaves the same as globalAppMiddleware: { isEnabled: true } #528

Merged
merged 5 commits into from
Oct 11, 2023
Merged

globalAppMiddleware: true behaves the same as globalAppMiddleware: { isEnabled: true } #528

merged 5 commits into from
Oct 11, 2023

Conversation

Timbological
Copy link
Contributor

Closes #527

Checklist:

  • issue number linked above after pound (#)
    • replace "Closes " with "Contributes to" or other if this PR does not close the issue
  • manually checked my feature / checking not applicable
  • wrote tests / testing not applicable
  • attached screenshots / screenshot not applicable

@Timbological
Copy link
Contributor Author

Errors should be fixed in new commit

@zoey-kaiser
Copy link
Member

Errors should be fixed in new commit

Sadly not yet 🥲

@Timbological
Copy link
Contributor Author

Ok, I'll remember to lint next time
Should be fixed now!

@zoey-kaiser zoey-kaiser merged commit 6434f53 into sidebase:main Oct 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

globalAppMiddleware: true behaves differently to globalAppMiddleware: { isEnabled: true }
2 participants
@Timbological @zoey-kaiser