Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Make 0.6.0 docs main documentation #566

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

zoey-kaiser
Copy link
Member

@zoey-kaiser zoey-kaiser commented Nov 13, 2023

Makes the 0.6.0 docs the default docs. Does not remove the 0.5.0 docs to ensure we keep these archived. A follow up Pr on https://github.com/sidebase/docs is required and will be linked here.

Edit: Sister PR can be found here: sidebase/docs#149

@zoey-kaiser zoey-kaiser marked this pull request as ready for review November 13, 2023 14:14
@BracketJohn
Copy link
Contributor

I'm a bit overwhelmed byu these changes: What is happening here? Why do we have to switch around all dirs and cannot just point latest to v0.6 and be happy?

@zoey-kaiser
Copy link
Member Author

I'm a bit overwhelmed byu these changes: What is happening here? Why do we have to switch around all dirs and cannot just point latest to v0.6 and be happy?

The problem is, that we had all the old links (on google, other pages etc.) never point to a version of the docs. If we were to leave them in that folder, we would need to update all the links, wait for google to update etc.

This would make a lot of problems. It would have been nicer if we from the very beginning had versioned paths, but as we did not do this, we now have this issue.

@BracketJohn
Copy link
Contributor

I see, but will this be resolved from now on / can we switch to the versioned approach now?

@zoey-kaiser
Copy link
Member Author

I see, but will this be resolved from now on / can we switch to the versioned approach now?

It would either:

  • Point all existing links and google searches (for a while until it updates) to a 404 (if we move the old docs into /v0.5)
  • Open outdated documentation if we keep the order as it is right now.

I don't think this is something we can tackle today.

@BracketJohn
Copy link
Contributor

Can't we:

  • keep current documentation under current path
  • start with versioned documentation for v0.6
  • also copy the current documentation to v0.5
  • point latest to 0.6

? This way:

  • we have an upgrade path that leads into versioning
  • current users links will not break (there are likely people out there who have bookmarked or linked from their code to our docs, this change would lead them suddenly loading v0.6 docs)

so basically we have:

  • /nuxt-auth/v0.6/ <- latest points to this
  • /nuxt-auth/v0.5/
  • /nuxt-auth/ <- this stays v0.5 for some time (or even better 301 redirects to /v0.5)

Otherwise I do not know if I'm comfortable with this (then rushed) switch, due to it breaking the references many people potentially keep

Copy link
Contributor

@BracketJohn BracketJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@zoey-kaiser
Copy link
Member Author

point latest to 0.6

This is something we attempted during the initial versioning PR. The problem I ran into was that I could not create catch all redirects.
What this essentially means:

  • I would need to create a md file for every route we used to have in the docs and point each file to the new docs.

I would have loved to have a catch all route that says:

  • If link has nuxt-auth/X point to nuxt-auth/v0.6/X, but this is not possible.

See nuxt-themes/docus#829 for the previous investigation.

@BracketJohn
Copy link
Contributor

Ok, and applying this solution without the redirect?

@zoey-kaiser
Copy link
Member Author

zoey-kaiser commented Nov 13, 2023

Ok, and applying this solution without the redirect?

This would result in many of our old links being inaccessible. This includes google search results until google updates them, which could take a while.

Definitely breaking:

  • All the links referenced on the docs page (would need to be updated, however definitly do-able)
  • All the twitter links (not do-able)
  • Any link posted on our discord (between us or users, not do-able)
  • Google search (for a while, as google needs to reindex everything)
  • Search (would require a reindex as well, do-able)
  • Github issues (would be broken, not do-able)

I am really against this, as we lose a lot of the connections we already have.

@zoey-kaiser
Copy link
Member Author

Added the banner as agreed:

Screenshot 2023-11-13 at 16 02 43

@BracketJohn
Copy link
Contributor

Nit: It should probably be "You are viewing the docs for the newest version. [...]"

@zoey-kaiser
Copy link
Member Author

Nit: It should probably be "You are viewing the docs for the newest version. [...]"

True, good catch

Screenshot 2023-11-13 at 16 08 14

@zoey-kaiser zoey-kaiser merged commit 7e65486 into main Nov 13, 2023
3 checks passed
@zoey-kaiser zoey-kaiser deleted the update-0.6-docs branch November 13, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants