fix: move vue server plugin out of server/ directory
#639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We might relax some rules to "warning only" for import protections also reducing chance of breaking Nuxt users by upstream change. but definitely makes sense to refactor this way 👍🏼 |
BracketJohn
approved these changes
Jan 17, 2024
|
with this fix, it is now possible to build the app without crashing it or silently failed it once in production. A quick patch release would be welcome @zoey-kaiser 😍 |
Released in https://github.com/sidebase/nuxt-auth/releases/tag/0.6.5! Sorry for the wait, I was coming home from a trip ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently apply some protections to help users avoid importing nitro in the vue part of the app and vice versa.
With nuxt/nuxt#25162 we expanded the test cases (and now test for
server\/(api|routes|middleware|plugins)\/).We might relax this regexp (cc: @pi0) as it wasn't originally intended to catch module usage (it might be helpful to keep anyway!) but I spotted that your Nuxt server plugin was in the
server/directory when I think it would more helpfully belong in theplugins/directory, mirroring a normal Nuxt project.Checklist:
#)