Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update local and refresh providers guide #641

Merged
merged 7 commits into from
Feb 24, 2024
Merged

docs: update local and refresh providers guide #641

merged 7 commits into from
Feb 24, 2024

Conversation

MuhammadM1998
Copy link
Contributor

Resolves #606.

This updates the local & refresh providers docs to indicate that we can pass any payload to the signIn method, not just a user & password. I've also added an example and reworded some parts that I felt was not clear enough. Feel free to reedit if needed 🙏

@zoey-kaiser
Copy link
Member

Hi @MuhammadM1998 👋

Thanks for updating the docs so thoroughly! I am doing a release at the moment, which is why I quickly wanted to chim in here. I will look at these docs in the coming days. As your docs can update, whichout doing a release, ill prio this after the PRs with code changes!

@MuhammadM1998
Copy link
Contributor Author

Nice to know thanks! Waiting for the release and the new session pointer 👀

@zoey-kaiser zoey-kaiser added p4 Important Issue documentation A change to the documentation labels Feb 23, 2024
zoey-kaiser
zoey-kaiser previously approved these changes Feb 23, 2024
@zoey-kaiser
Copy link
Member

Hi @MuhammadM1998 👋

Please resolve the merge conflicts and then we can merge this! AFAIK This will also fix an issue in our changes:

The backend response returns an object named token not a single value. See the references to this here: #649

@MuhammadM1998
Copy link
Contributor Author

@zoey-kaiser The conflict is fixed now. Feel free to quickly rereview

Copy link
Member

@zoey-kaiser zoey-kaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit 😄

docs/content/1.getting-started/3.quick-start.md Outdated Show resolved Hide resolved
@zoey-kaiser
Copy link
Member

Amazing! Thank you so much for the changes. I think you really improved the docs for the refresh provider. I apologize for it taking longer to merge this PR, the start of the year was pretty crazy!

@zoey-kaiser zoey-kaiser linked an issue Feb 24, 2024 that may be closed by this pull request
@zoey-kaiser zoey-kaiser merged commit d53b606 into sidebase:main Feb 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation A change to the documentation p4 Important Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom login body How to use Refresh Token
2 participants