Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/adding refresh token body key to refresh provider #690

Conversation

hdood
Copy link

@hdood hdood commented Feb 27, 2024

πŸ”— Linked issue

#689

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Add requestbodyKey to module.ts which will allow us to change refresh token body key in refresh request.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@zoey-kaiser zoey-kaiser added p4 Important Issue provider-local An issue with the local provider provider-refresh An issue with the refresh provider labels Mar 4, 2024
@zoey-kaiser
Copy link
Member

Hi @hdood πŸ‘‹

Thank you for your contribution. Please resolve the merge conflicts and then we should be able to review your PR this week πŸ€—

@hdood
Copy link
Author

hdood commented Mar 4, 2024

Hi @zoey-kaiser

I've resolved the merge conflicts, this is my second PR so if there any other error please let me know and i will fix it right away.

@zoey-kaiser
Copy link
Member

Hi @hdood,

Please check that the tests are passing! Then we can begin with a proper review πŸ€—

@zoey-kaiser
Copy link
Member

Hi @hdood πŸ‘‹

We have opened a new PR (#727) with this change, as this PR has gotten Stale. Thank you for your contribution!

@zoey-kaiser zoey-kaiser closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4 Important Issue provider-local An issue with the local provider provider-refresh An issue with the refresh provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants