Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#673, #523, #848): back-port authjs migration #849

Merged
merged 8 commits into from
Aug 20, 2024

Conversation

phoenix-ru
Copy link
Collaborator

@phoenix-ru phoenix-ru commented Aug 8, 2024

🔗 Linked issue

Relates to #673, #523, #848

This is a (partial) back-port of #818 to current code. Because completely updating to @auth/core makes the module very unstable, we decided to instead back-port the advancements made in the PR to also prepare for a future update.

Differences with #818 :

  • no @auth/core version bump;
  • internal helpers are preserved because they seem to work better than these of @auth/core;
  • no breaking changes.

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@phoenix-ru phoenix-ru added the enhancement An improvement that needs to be added label Aug 8, 2024
@phoenix-ru phoenix-ru requested a review from zoey-kaiser August 8, 2024 13:35
@phoenix-ru phoenix-ru changed the title feat(#673, #811, #848): back-port authjs migration feat(#673, #523, #848): back-port authjs migration Aug 8, 2024
Copy link
Member

@zoey-kaiser zoey-kaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • When I started the playground I got the following warning spammed in the console (c1). Note: This only occurs when a unauthenticated user visits the site

C1:

 WARN  [nuxt] useAsyncData must return a value (it should not be undefined) or the request may be duplicated on the client side.

@phoenix-ru
Copy link
Collaborator Author

When I started the playground I got the following warning spammed

This is likely related to dependencies. I will run an additional update cycle and see if that resolves the problem for you

@phoenix-ru
Copy link
Collaborator Author

Documented the issue here (tldr; it is not caused by us):
nuxt/nuxt#28096 (comment)

Copy link
Member

@zoey-kaiser zoey-kaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the investigation! The workaround does remove the warning message. I see no reason to not move forward with merging this PR.

However, let's discuss how this PR integrates into our planned migration to authjs and what the next steps are prior to merging 😊

@zoey-kaiser zoey-kaiser merged commit 355e865 into main Aug 20, 2024
5 checks passed
@zoey-kaiser zoey-kaiser deleted the feature/backport-authjs-migration branch August 20, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement that needs to be added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants