-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#673, #523, #848): back-port authjs migration #849
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- When I started the playground I got the following warning spammed in the console (c1). Note: This only occurs when a unauthenticated user visits the site
C1:
WARN [nuxt] useAsyncData must return a value (it should not be undefined) or the request may be duplicated on the client side.
This is likely related to dependencies. I will run an additional update cycle and see if that resolves the problem for you |
Documented the issue here (tldr; it is not caused by us): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the investigation! The workaround does remove the warning message. I see no reason to not move forward with merging this PR.
However, let's discuss how this PR integrates into our planned migration to authjs and what the next steps are prior to merging 😊
🔗 Linked issue
Relates to #673, #523, #848
This is a (partial) back-port of #818 to current code. Because completely updating to
@auth/core
makes the module very unstable, we decided to instead back-port the advancements made in the PR to also prepare for a future update.Differences with #818 :
@auth/core
version bump;@auth/core
;❓ Type of change
📚 Description
📝 Checklist