-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Refresh not triggered if the access token is not also known, which limits its purpose #902
Open
cip8
wants to merge
3
commits into
sidebase:main
Choose a base branch
from
cip8:refresh_authtoken_optional
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,7 @@ export default defineNuxtPlugin({ | |
const { rawToken, rawRefreshToken, refreshToken, token, lastRefreshedAt } | ||
= useAuthState() | ||
|
||
if (refreshToken.value && token.value) { | ||
if (refreshToken.value) { | ||
const config = nuxtApp.$config.public.auth | ||
const configToken = useTypedBackendConfig(useRuntimeConfig(), 'local') | ||
|
||
|
@@ -20,10 +20,12 @@ export default defineNuxtPlugin({ | |
const { path, method } = provider.refresh.endpoint | ||
const refreshRequestTokenPointer = provider.refresh.token.refreshRequestTokenPointer | ||
|
||
// include header in case of auth is required to avoid 403 rejection | ||
const headers = new Headers({ | ||
[configToken.token.headerName]: token.value | ||
} as HeadersInit) | ||
const headers = new Headers() | ||
|
||
// To perform the refresh, some backends may require the auth token to also be set. | ||
if (token.value) { | ||
headers.set(configToken.token.headerName, token.value) | ||
} | ||
|
||
try { | ||
const response = await _fetch<Record<string, any>>(nuxtApp, path, { | ||
|
@@ -40,8 +42,7 @@ export default defineNuxtPlugin({ | |
console.error( | ||
`Auth: string token expected, received instead: ${JSON.stringify( | ||
extractedToken | ||
)}. Tried to find token at ${ | ||
provider.token.signInResponseTokenPointer | ||
)}. Tried to find token at ${provider.token.signInResponseTokenPointer | ||
} in ${JSON.stringify(response)}` | ||
Comment on lines
-44
to
46
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you please not apply stylistic changes? Thanks |
||
) | ||
return | ||
|
@@ -57,8 +58,7 @@ export default defineNuxtPlugin({ | |
console.error( | ||
`Auth: string token expected, received instead: ${JSON.stringify( | ||
extractedRefreshToken | ||
)}. Tried to find token at ${ | ||
provider.refresh.token.signInResponseRefreshTokenPointer | ||
)}. Tried to find token at ${provider.refresh.token.signInResponseRefreshTokenPointer | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same |
||
} in ${JSON.stringify(response)}` | ||
) | ||
return | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been trying to understand why is this required - could you please clarify that?