This repository has been archived by the owner on Dec 12, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make mandatory session properties immutable #54
base: main
Are you sure you want to change the base?
Make mandatory session properties immutable #54
Changes from all commits
565947c
91e9fe8
3a93dc3
98ecd11
5d000e4
660b6ed
564cbf5
f35461a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and, sorry to kind of push this in here, but as we're already working on the
Session
interface: Would you consider adapting theh3
event context as done here:https://github.com/sidebase/nuxt-prisma/blob/b1ffd717cf1061215498fa8e9b90ce62cac8b494/src/runtime/server/middleware/prisma.ts#L7-L11
whuile you're add it? This way, typing for the end-user should improve when they access
event.context.session
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added it, but somehow the types aren't available when packed and imported as module in a project. Any suggestions?