feat: support --cache-from/--cache-imports #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspiration taken from the dockerfile frontend. Signed-off-by: Andrey Smirnov <[email protected]>
smira
force-pushed
the
feat/cache-from
branch
from
3539c91
to
20de986
Compare
frezbo
reviewed
Sep 15, 2023
| var cacheImports []client.CacheOptionsEntry | ||
|
|
||
| // new API | ||
| if cacheImportsStr := opts[keyCacheImports]; cacheImportsStr != "" { |
There was a problem hiding this comment.
we could actually pass in json and drop old api support at all if needed
There was a problem hiding this comment.
I'm not sure if buildx supports new API fully, this "new" API is 5 years old now
frezbo
approved these changes
Sep 15, 2023
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspiration taken from the dockerfile frontend.