fix: have a default worker group #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure there's a default worker group. Also bump TF provider. Signed-off-by: Noel Georgi <[email protected]>
Unix4ever
approved these changes
Aug 28, 2023
|
/m |
TimJones
approved these changes
Aug 28, 2023
frezbo
commented
Aug 28, 2023
| @@ -384,6 +384,6 @@ data "talos_cluster_kubeconfig" "this" { | |||
|
|
|||
| client_configuration = talos_machine_secrets.this.client_configuration | |||
| endpoint = module.talos_control_plane_nodes.0.public_ip | |||
| node = module.talos_control_plane_nodes.0.public_ip | |||
| node = module.talos_control_plane_nodes.0.private_ip | |||
There was a problem hiding this comment.
we can switch back to private address since the TF provider bug is fixed
frezbo
commented
Aug 28, 2023
| @@ -55,7 +55,9 @@ variable "worker_groups" { | |||
| ) | |||
| error_message = "The ami_id value must be a valid AMI id, starting with \"ami-\"." | |||
| } | |||
| default = [] | |||
| default = [{ | |||
| name = "default" | |||
There was a problem hiding this comment.
this is the actual change
added comments, I'll add the lingust generated for these files in the next PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure there's a default worker group. Also bump TF provider.