chore: move udev rules #501
Open
+12
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: siderolabs/pkgs#1053 Signed-off-by: Dmitry Sharshakov <[email protected]>
frezbo
reviewed
Oct 22, 2024
| @@ -51,7 +51,7 @@ steps: | |||
| -Dno_systemd=true \ | |||
| -Dprefix=/usr/local \ | |||
| -Discsi_sbindir=/usr/local/sbin \ | |||
| -Drulesdir=/usr/local/etc/udev/rules.d \ | |||
| -Drulesdir=/usr/lib/udev/rules.d \ | |||
There was a problem hiding this comment.
I this this is the default setting in most packages, if so I guess we can drop the config even
There was a problem hiding this comment.
The interesting thing is we don't have anything accessing /usr/local/etc
There was a problem hiding this comment.
Should I perhaps just remove this config line? And the similar path in nut-client?
There was a problem hiding this comment.
yes, let's do that as long as it installs the default rules at the right location
There was a problem hiding this comment.
we also need to bump extensions-validator
smira
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: siderolabs/pkgs#1053
Signed-off-by: Dmitry Sharshakov [email protected]