fix: kernel partition sync when overwriting GPT #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a second method to handle the case when the partition table is fully overwritten. See siderolabs/talos#9701 Signed-off-by: Andrey Smirnov <[email protected]>
smira
force-pushed
the
fix/gpt-overwrite
branch
from
40683ff to
5bff648
Compare
dsseng
reviewed
Nov 13, 2024
|
|
||
| // syncKernelComplete synchronizes the kernel partition table with the current table by overwriting the whole table. | ||
| // | ||
| // It is incompatible with mounted partitions. |
There was a problem hiding this comment.
Wasn't there a syscall to just tell the kernel to re-read the partition table? Also we must probably check this is not running on a disk which has a mounted partition and return an error if so
There was a problem hiding this comment.
The idea is that if something calls gpt.New vs. gpt.Read then we know that whatever existing partitions are going to be removed.
The call would fail if the mounted partitions are there, but it's not the job of this library to handle that (it should be handled in the layer up).
There was a problem hiding this comment.
And by that syscall I meant BLKRRPART to be clear
frezbo
approved these changes
Nov 13, 2024
dsseng
approved these changes
Nov 13, 2024
|
/m |
smira
added a commit
to smira/talos
that referenced
this pull request
Nov 13, 2024
Fixes siderolabs#9701 See siderolabs/go-blockdevice#115 Signed-off-by: Andrey Smirnov <[email protected]>
smira
added a commit
to smira/talos
that referenced
this pull request
Dec 12, 2024
Fixes siderolabs#9701 See siderolabs/go-blockdevice#115 Signed-off-by: Andrey Smirnov <[email protected]> (cherry picked from commit 8a7476c)
smira
added a commit
to smira/talos
that referenced
this pull request
Dec 12, 2024
Fixes siderolabs#9701 See siderolabs/go-blockdevice#115 Signed-off-by: Andrey Smirnov <[email protected]> (cherry picked from commit 8a7476c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a second method to handle the case when the partition table is fully overwritten.
See siderolabs/talos#9701