feat: implement device wiping by signatures #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to wipe specific signatures which are used to detect filesystems and partitions. This is important for cases like this one: * create a GPT partition table * format filesystems * wipe the whole device * re-create GPT partition table with exactly same layout * if the signatures for filesystems haven't been properly wiped, the filesystem will re-appear The previous implementation only wiped first and last 1MB which enough to wipe GPT, but not all filesystems. Probe now returns offsets of signatures to be wiped. Fixed some bugs, including extra "recovery" of GPT from alternate header if the primary is completely zeroed out. Fixes siderolabs/talos#9724 Fixes siderolabs/talos#9530 Signed-off-by: Andrey Smirnov <[email protected]>
frezbo
approved these changes
Nov 15, 2024
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to wipe specific signatures which are used to detect filesystems and partitions.
This is important for cases like this one:
The previous implementation only wiped first and last 1MB which enough to wipe GPT, but not all filesystems.
Probe now returns offsets of signatures to be wiped.
Fixed some bugs, including extra "recovery" of GPT from alternate header if the primary is completely zeroed out.
Fixes siderolabs/talos#9724
Fixes siderolabs/talos#9530